Skip to content

Calling present? and blank? on a Spina::Part::Image can be the same #1439

Open

Description

@aseroff

Based on

def present?
signed_blob_id.present?
end

calling present? on an image part works as intended. But calling blank? cannot be relied on to produce the opposite value: an empty image part returns false for blank?

Not sure if anyone but my linter cares, and I can just as easily whitelist instances of !image_part.present?, but figured I'd bring it up.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions