Repository navigation
Fix S3966 FP: Rule does not recognize that a new instance is created after the disposal #9799
Description
Description
This code generates S3966 erroneously detecting f has already been disposed in the 'finally' block and not realising a new instance was assigned in the 'if'.
Reproducer
public class Foo : IDisposable
{
public void Dispose()
{
}
public static void Bar(bool x)
{
var f = new Foo();
try
{
if (x)
{
f.Dispose();
f = new Foo();
}
}
finally
{
f.Dispose();
}
}
}Product and Version
SonarAnalyzer.CSharp Version 10.17.0.131074
Activity
mary-georgiou commentedon Mar 25, 2026
Hello @paulhickman-ec,
I confirm this is an FP.
thanks for the report.
[-]Fix S3966 FP: Detects[/-][+]NET-3470 Fix S3966 FP: Detects[/+]github-actions commentedon Mar 25, 2026
Internal ticket NET-3470
[-]NET-3470 Fix S3966 FP: Detects[/-][+]Fix S3966 FP: Rule does not recognize that a new instance is created after the disposal[/+]