Conversation
|
@codex review it, and make sure related Paper API matches our minimal minecraft version requirement (1.18). |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: aa4e354d8c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
fd71ca5 to
8951801
Compare
StarWishsama
left a comment
StarWishsama
left a comment
There was a problem hiding this comment.
如果你正在用 LLM 实现，不要做过多防御性编程、测试点到即止、最小化完成目标，善用项目中的 codegraph 等辅助框架
| if (backpacks.containsKey(p.getUniqueId())) { | ||
| p.closeInventory(); | ||
| UUID playerUuid = p.getUniqueId(); | ||
| UUID requestToken = UUID.randomUUID(); |
There was a problem hiding this comment.
为什么要额外引入一个 session？正常处理一些未处理到的边界情况即可
| public void onClick(InventoryClickEvent e) { | ||
| if (!openingPlayers.isEmpty() | ||
| && openingPlayers.contains(e.getWhoClicked().getUniqueId())) { | ||
| if (e.getWhoClicked() instanceof Player player) { |
There was a problem hiding this comment.
This event is called when a player clicks in an inventory.
|
合并分支目标改为 master, dev 分支已弃用 |
8951801 to
b5a860e
Compare
This branch has not been deployed
2 participants
修复某些情况下背包的打开状态会被卡住且重进无法恢复的问题