Repository navigation
feat: explain reordered levels and catch tied page order - #10
Merged
Merged
Conversation
Make a level whose pages are in a different order on the target easy to understand, and stop reporting such a level as in sync when the target's order is undefined. - Rows marked out of date only because their level's order differs are labeled "Order differs on target". The status is still Out of date, so sorting and filters are unchanged. - The comparer finds the fewest pages out of place (the pages outside a longest increasing run of target order values) and carries them, with the level's parent, on each reordered row. The tooltip names them, gives the usual cause (a partial sync) and the fix (Sync with all subpages on the parent). - Pages that share an order value on the target count as out of order. A partial sync leaves such ties, and Kentico then shows them in whatever order the database returns; the previous GUID tie-break could report the level as in sync while the target showed it differently. - Add a Usage Guide entry on why a whole level shows "Order differs on target", and update the foundation and admin page specs, including the end-to-end check on the rig.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes a reordered level easy to understand, and fixes a case where a level was reported as in sync while the target showed it in a different order.
Why
Syncing only some pages of a level is the usual way to end up with a different page order on the target: Content Sync sends each synced page's order value, and the pages left out keep theirs. The status page then marked the whole level "Out of date on target", with the only explanation in a tooltip and no hint of which page was out of place.
Changes
ContentSyncStatusItem.Reorder). The tooltip reads, for example: "Page order on this level differs on the target: Coffee Beverages Explained is in a different position there. This usually happens when only some pages of a level are synced. To fix it, use Sync with all subpages on Articles." Up to 3 names, then "and N more"; the channel's top level says to sync all pages on the level. No wire change.Testing