Skip to content

[mac] fix: don't auto-quit under the open dialog when menubar mode is off - #406

Merged
Shpigford merged 1 commit into
mainfrom
issue-379
Aug 23, 2026
Merged

Shpigford merged 1 commit into
mainfrom
issue-379

Conversation

@Shpigford

Copy link
Copy Markdown
Owner

With "Keep running in menubar" disabled and no document open, the launcher dismissing at launch armed the 3-second deferred quit, which then fired while the open dialog (or About window) was still on screen — the queued terminate landed the moment the runloop changed modes, i.e. exactly when the user clicked a menu. Both the deferred-quit timer and the last-window-closed path now bail while any user-facing window (modal panel, or any visible window at level ≤ .modalPanel — so the Scratchpads status item and menu windows don't count) is on screen. Dismissing those without opening a document still quits via the normal last-window-closed path.

Fixes #379

… off (#379)

With 'Keep running in menubar' disabled and no document open, the
launcher dismissing at launch armed the 3s deferred quit, which then
fired while the open dialog (or About window) was still on screen —
terminating the app the moment the runloop changed modes, i.e. exactly
when the user touched a menu.

The deferred quit and the last-window-closed path now bail while any
user-facing window (level <= modalPanel, so the status item and menu
windows don't count) or modal panel is visible. If the user dismisses
those without opening a document, the normal last-window-closed quit
still applies.
@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying clearly with  Cloudflare Pages  Cloudflare Pages

Latest commit: a61835e
Status: ✅  Deploy successful!
Preview URL: https://df96ec04.clearly-cjz.pages.dev
Branch Preview URL: https://issue-379.clearly-cjz.pages.dev

View logs

@Shpigford
Shpigford merged commit dbe1c2e into main Aug 23, 2026
3 checks passed
@Shpigford
Shpigford deleted the issue-379 branch August 23, 2026 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

When disabling "Keep running in the menubar" the app auto-quits all the time

1 participant