Repository navigation
Conversation
… off (#379) With 'Keep running in menubar' disabled and no document open, the launcher dismissing at launch armed the 3s deferred quit, which then fired while the open dialog (or About window) was still on screen — terminating the app the moment the runloop changed modes, i.e. exactly when the user touched a menu. The deferred quit and the last-window-closed path now bail while any user-facing window (level <= modalPanel, so the status item and menu windows don't count) or modal panel is visible. If the user dismisses those without opening a document, the normal last-window-closed quit still applies.
Deploying clearly with
|
| Latest commit: |
a61835e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://df96ec04.clearly-cjz.pages.dev |
| Branch Preview URL: | https://issue-379.clearly-cjz.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With "Keep running in menubar" disabled and no document open, the launcher dismissing at launch armed the 3-second deferred quit, which then fired while the open dialog (or About window) was still on screen — the queued terminate landed the moment the runloop changed modes, i.e. exactly when the user clicked a menu. Both the deferred-quit timer and the last-window-closed path now bail while any user-facing window (modal panel, or any visible window at level ≤ .modalPanel — so the Scratchpads status item and menu windows don't count) is on screen. Dismissing those without opening a document still quits via the normal last-window-closed path.
Fixes #379