Skip to content

[mac] fix: avoid retaining external-change activation observers - #405

Merged
Shpigford merged 1 commit into
mainfrom
fix/external-change-observer-cleanup
Aug 23, 2026
Merged

Shpigford merged 1 commit into
mainfrom
fix/external-change-observer-cleanup

Conversation

@Shpigford

Copy link
Copy Markdown
Owner

Follow-up to #401.

Summary

  • register the one-shot activation observer only while Clearly is inactive
  • prevent foreground external writes from retaining document/view closures until a later app switch
  • preserve the immediate foreground clear and deferred background activation clear

Verification

  • xcodebuild -project Clearly.xcodeproj -scheme Clearly -configuration Debug -derivedDataPath ./.build/DerivedData build
  • swift test --package-path Packages/ClearlyCore (101 XCTest + 21 Swift Testing)
  • live app: foreground external reload stayed clean
  • live app: background external reload cleared on activation and closed without a save prompt

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying clearly with  Cloudflare Pages  Cloudflare Pages

Latest commit: 26a4a5f
Status: ✅  Deploy successful!
Preview URL: https://ee62ac62.clearly-cjz.pages.dev
Branch Preview URL: https://fix-external-change-observer.clearly-cjz.pages.dev

View logs

@Shpigford
Shpigford merged commit 414d381 into main Aug 23, 2026
3 checks passed
@Shpigford
Shpigford deleted the fix/external-change-observer-cleanup branch August 23, 2026 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant