perf(emoji): drop unused fields from emoji.json - #1259
Open
jasp-nerd wants to merge 2 commits into
Open
Conversation
category and subgroup are never read; group covers the emote set grouping and the tooltip. Cuts emoji.json from 623KB to 388KB and shrinks the parsed list held in memory by every chat tab.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
categoryandsubgroupinemoji.jsonare never read;groupcovers the emote set grouping and the tooltip. Dropping them cuts the file from 623KB to 388KB and shrinks the parsed list every chat tab keeps in memory. Built and typechecked against master.Types of changes
What types of changes does your code introduce to 7TV?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.