fix(twitch/chat): show moderator name on timeout/ban messages - #1257
Open
BennyyyBB wants to merge 1 commit into
Open
fix(twitch/chat): show moderator name on timeout/ban messages#1257BennyyyBB wants to merge 1 commit into
BennyyyBB wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
According to issue #1237 Mods could not see who performed a timeout/ban in Twitch Chat,
With this fix "UserMessage.vue" rendes 'msg.moderation.actor''s name in the ban-state label when present and "ChatList.vue" now preserves an already-resolved "actor" instead of unconditionally resetting it to 'null'.
(Non-moderator viewers still won't see the actor's name, since Twitch never sends them the moderation_action topic in the first place as that's expected and unchanged.)
vue-tsc --noEmit and eslint on changed files showed no errors while testing, but I would appreaciate a test from someone with mod access on a channel testing this in a live chat.
Types of changes
Checklist