Repository navigation
Fix integer precision in CLI numeric filters - #213
Open
HocVoNgThai wants to merge 1 commit into
Open
HocVoNgThai wants to merge 1 commit into
HocVoNgThai wants to merge 1 commit into
Conversation
SethMMorton
reviewed
Nov 19, 2026
| args = parser.parse_args(arguments or None, namespace=TypedArgs()) | ||
|
|
||
| if args.number_type in _FLOAT_MODES: | ||
| # Convert via strings so oversized integer literals still become infinity. |
Owner
There was a problem hiding this comment.
It took me a lot of reading this over and over to realize that it was not just throwing away the benefit of using integers for large numbers. Expanding the comments to explain that we letting these become infinity so that it is apples-to-apples comparisons with float would be helpful.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CLI numeric filters convert integer bounds and extracted tokens to float, causing distinct large integers to compare equal.
For example, excluding
9007199254740992also removesitem9007199254740993. This change keeps the latter entry and accepts ranges between these adjacent integers.Preserve integer precision in integer modes and add regression coverage for exclusion, filtering, and reverse filtering.