Repository navigation
Install Rust in FreeBSD CI so hypothesis can build from source - #207
Merged
Merged
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #207 +/- ##
=======================================
Coverage 97.80% 97.80%
=======================================
Files 10 10
Lines 637 637
=======================================
Hits 623 623
Misses 14 14 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The "Test on FreeBSD" job in the
Testsworkflow has been failing onmain(e.g. https://github.com/SethMMorton/natsort/actions/runs/35458022900/job/105936667289) while installing the test dependencies, before any test runs.Root cause
Recent hypothesis releases do not publish a wheel for FreeBSD, so
pip install hypothesisinside the FreeBSD VM falls back to building from the sdist. That build needs a Rust toolchain (it is built with maturin), and the VM is only prepared withpkg install -y python3, so the build fails.Change
Install
rustalongsidepython3in thepreparestep of the FreeBSD job:No other files are touched.
Verification
I ran the workflow on my fork with this change:
pytest --hypothesis-profile=slow-testsreported355 passed. The source build adds about 4.5 minutes to the job.The
Code Quality/ "Static Analysis" job also fails on my fork run, but it fails identically onmain(ruff errors tracked in #200) and is unrelated to this change.Fixes #201
This change was prepared with the help of Cursor CLI (AI-assisted); I reviewed the diff and the CI logs myself before opening the PR.