Skip to content

fix generated columns not being discovered - #161

Merged
tyt2y3 merged 6 commits into
SeaQL:masterfrom
sinder38:fix/sqlite-generated-columns
Mar 10, 2026
Merged

tyt2y3 merged 6 commits into
SeaQL:masterfrom
sinder38:fix/sqlite-generated-columns

Conversation

@sinder38

@sinder38 sinder38 commented Mar 10, 2026 •

Copy link
Copy Markdown
Contributor

@sinder38
sinder38 marked this pull request as draft March 10, 2026 17:05
@sinder38
sinder38 force-pushed the fix/sqlite-generated-columns branch from 194d166 to 127c548 Compare March 10, 2026 17:13
@sinder38
sinder38 force-pushed the fix/sqlite-generated-columns branch from 127c548 to 5866f6c Compare March 10, 2026 17:26
@sinder38
sinder38 marked this pull request as ready for review March 10, 2026 17:37
@sinder38

Copy link
Copy Markdown
Contributor Author

@Huliiiiii it is ready

@Huliiiiii
Huliiiiii requested a review from tyt2y3 March 10, 2026 18:24
@tyt2y3

tyt2y3 commented Mar 10, 2026

Copy link
Copy Markdown
Member

we need to fix the CI failure before merge

@sinder38

Copy link
Copy Markdown
Contributor Author

Please, can we get automatic CI runs in branches? It would make testing much easier

@sinder38

Copy link
Copy Markdown
Contributor Author

huh?
image

@sinder38

sinder38 commented Mar 10, 2026 •

Copy link
Copy Markdown
Contributor Author

Okay, I figured it out. my rust was on just 1.92 and not 1.94.
The real question are:
Why is existing code non-Clippy compliant?
Should I fix it here, in this PR?

@tyt2y3

tyt2y3 commented Mar 10, 2026

Copy link
Copy Markdown
Member

I think it's just latest stable clippy always has some new lints.
don't worry about clippy then

@tyt2y3

tyt2y3 commented Mar 10, 2026 •

Copy link
Copy Markdown
Member

Please, can we get automatic CI runs in branches? It would make testing much easier

we do. once we merged this PR! your PRs will run automatically. there's a "first contributor" condition

@tyt2y3
tyt2y3 merged commit b6dfdb1 into SeaQL:master Mar 10, 2026
26 of 27 checks passed
@sinder38
sinder38 deleted the fix/sqlite-generated-columns branch March 10, 2026 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Column extra causes sync to add column again

3 participants