fix: pin cli_version in initialize and update actions - #14
Closed
nicomiguelino wants to merge 2 commits into
Closed
Conversation
The Deploy Edge App step called screenly/cli@master without a cli_version override, so it silently inherited whatever default Screenly/cli's action.yml set, which was v1.1.1, a release that predates Screenly/cli#284. That PR removed the hard error guard that failed deploys with "No changes detected" when there was nothing to upload. The fix is included starting in v1.2.0. Screenly/cli's action.yml default has been bumped separately, but this adds an explicit cli_version input here too, defaulting to v1.2.1, so this action is not silently exposed to whatever default Screenly/cli ships next.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the update composite action to make the Screenly CLI version explicitly configurable (and defaulted to a known-good version) rather than implicitly relying on whatever default screenly/cli provides.
Changes:
- Add a new
cli_versioninput to theupdateaction (defaulting tov1.2.1). - Pass the new input through to the
screenly/cli@masterstep viawith.cli_version.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Rework the cli_version override to be a constant set via GITHUB_ENV in each action's build-system detection step, rather than exposing it as a public input. Also apply the same pin to initialize/action.yml, which has its own set of screenly/cli@master steps.
nicomiguelino
changed the title
Contributor
Author
|
Now that Screenly/cli#305 is merged, these changes are not required anymore. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary