Skip to content

duckstation(-preview): Modernise manifest - #1867

Open
Mahir007 wants to merge 1 commit into
ScoopInstaller:masterfrom
Mahir007:duckstation-updates
Open

Mahir007 wants to merge 1 commit into
ScoopInstaller:masterfrom
Mahir007:duckstation-updates

Conversation

@Mahir007

Copy link
Copy Markdown
Contributor

This pr contains a plethora of changes:

  • the version string is now YYYYMMDDHHMMSS-<commit> with no unnecessary g prefix. this is due to the fact that multiple releases can be made in a single day and currently scoop might or might not detect it being a newer version. adding time fixes this.
  • shortcuts are now made via the shortcuts field instead of post_install scripts. (the reason for the existing script is due to bugs found in [Bug]: Duckstation Fails to Open in Current Folder - Failed to open game list cache #1251, however, this is no longer an issue and so we can go back to using regular shortcut creation).
  • for the preview build, -preview added to the bin name to allow side-by-side installs with the stable release.
  • the pre_install migration script now accounts for a new location on user appdata. in addition, we now disable check for updates on migrated/fresh installs and fixed an issue that caused the first-run wizard to not show.
    lastly, to support new persist items, we create two files if they don't already exist
  • the post_install script now only create the portable.txt file.
  • for persist, we've removed the dump folder as that is no longer used and added: gameicons, patches, resources\themes, subchannels, videos, watches, custom_properties.ini & playtime.dat (all verified to have, or have the potential to have user data that one would want version to version)
  • the pre_uninstall script now saves custom_properties.ini (newly added to persist), and no longer errors if a file is missing.
  • the post_uninstall script has been removed as its no longer necessary with the shortcuts change.
  • for checkver, it has had its regex updated to capture the release time to build the new version format.
  • on autoupdate, the arm64 URL casing is fixed (duckstation.json only).

@coderabbitai

coderabbitai Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

Explain Change →

Summary by CodeRabbit

  • Improvements
    • Existing DuckStation data is carried over from Documents or Local AppData during installation, and additional user data is preserved across updates.
    • DuckStation shortcuts are available from the installation, and portable-mode support is included.
    • Startup update checks are disabled in settings during installation.
    • Missing configuration and playtime files are created automatically.

Walkthrough

Both DuckStation manifests update version formatting and revise installation, data migration, and persistence configuration for stable and preview packages.

Changes

DuckStation manifests

Layer / File(s) Summary
Release version and launch setup
bucket/duckstation.json, bucket/duckstation-preview.json
Both manifests use timestamp-and-commit version formats. Architecture entries define executable and shortcut mappings. The preview package uses a distinct executable command and shortcut label. portable.txt creation moves to shared post-install commands. The stable ARM64 URL uses lowercase arm64.
Data migration and persistence
bucket/duckstation.json, bucket/duckstation-preview.json
Pre-install steps check the Documents and Local AppData locations, migrate the first existing directory, and disable startup update checks in its settings. Both manifests create missing custom_properties.ini and playtime.dat files, update persisted paths, and attempt to copy settings and custom properties before uninstall.
Merge Risk: Low · up to a0d11

Migration from an existing data directory could, in a rare disk-full case, delete the source data after an incomplete copy. Migrated settings with indented update-check entries may also keep update checks enabled. Both are narrow edge cases, so the change is mergeable with awareness.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title "duckstation(-preview): Modernise manifest" names the affected manifests (DuckStation and DuckStation Preview) and the general nature of the change. The changeset does modernise both manifes…
Description check Passed The description follows the template. It gives a clear summary of each change, including the new version format, shortcut move, preview binary rename, pre_install migration, persist changes, pre_unins…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title "duckstation(-preview): Modernise manifest" names the affected manifests (DuckStation and DuckStation Preview) and the general nature of the change. The changeset does modernise both manifests: it moves shortcut creation to the shortcuts field, updates the version format, and revises the install, uninstall, and persist logic. The title is broad, so it does not name the main specific change (the version format or shortcut move), but it refers to a real part of the change and is not misleading.

Full details: Description check

Explanation

The description follows the template. It gives a clear summary of each change, including the new version format, shortcut move, preview binary rename, pre_install migration, persist changes, pre_uninstall and post_uninstall updates, checkver regex, and the ARM64 URL fix. It keeps the contributing guide checkbox. The template's 'Closes #XXXX' or 'Relates to #XXXX' line is missing, so the linked issue is not stated. The author also checked the contributing guide box, and the note about #1251 gives context.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 6348bf69-6079-4789-9daa-6c92d43630b9
Commits

Reviewing files that changed from the base of the PR and between 59e9f4e and d0d4e56.

Files selected for processing: 2

  • bucket/duckstation-preview.json
  • bucket/duckstation.json

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 0 remain after this review.

Comment thread bucket/duckstation-preview.json Resolved
@Mahir007

Copy link
Copy Markdown
Contributor Author

/verify

@github-actions

Copy link
Copy Markdown
Contributor

All changes look good.

Wait for review from human collaborators.

duckstation-preview

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

duckstation

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Check the full log for details.

@Mahir007
Mahir007 force-pushed the duckstation-updates branch from d0d4e56 to a0d1123 Compare November 20, 2026 20:49

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 8cc60121-25b1-42f6-8ed7-c24ce4d57e83
Commits

Reviewing files that changed from the base of the PR and between d0d4e56 and a0d1123.

Files selected for processing: 2

  • bucket/duckstation-preview.json
  • bucket/duckstation.json

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.

Comment thread bucket/duckstation-preview.json Resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant