You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
the version string is now YYYYMMDDHHMMSS-<commit> with no unnecessary g prefix. this is due to the fact that multiple releases can be made in a single day and currently scoop might or might not detect it being a newer version. adding time fixes this.
for the preview build, -preview added to the bin name to allow side-by-side installs with the stable release.
the pre_install migration script now accounts for a new location on user appdata. in addition, we now disable check for updates on migrated/fresh installs and fixed an issue that caused the first-run wizard to not show.
lastly, to support new persist items, we create two files if they don't already exist
the post_install script now only create the portable.txt file.
for persist, we've removed the dump folder as that is no longer used and added: gameicons, patches, resources\themes, subchannels, videos, watches, custom_properties.ini & playtime.dat (all verified to have, or have the potential to have user data that one would want version to version)
the pre_uninstall script now saves custom_properties.ini (newly added to persist), and no longer errors if a file is missing.
the post_uninstall script has been removed as its no longer necessary with the shortcuts change.
for checkver, it has had its regex updated to capture the release time to build the new version format.
on autoupdate, the arm64 URL casing is fixed (duckstation.json only).
Existing DuckStation data is carried over from Documents or Local AppData during installation, and additional user data is preserved across updates.
DuckStation shortcuts are available from the installation, and portable-mode support is included.
Startup update checks are disabled in settings during installation.
Missing configuration and playtime files are created automatically.
Walkthrough
Both DuckStation manifests update version formatting and revise installation, data migration, and persistence configuration for stable and preview packages.
Changes
DuckStation manifests
Layer / File(s)
Summary
Release version and launch setup bucket/duckstation.json, bucket/duckstation-preview.json
Both manifests use timestamp-and-commit version formats. Architecture entries define executable and shortcut mappings. The preview package uses a distinct executable command and shortcut label. portable.txt creation moves to shared post-install commands. The stable ARM64 URL uses lowercase arm64.
Data migration and persistence bucket/duckstation.json, bucket/duckstation-preview.json
Pre-install steps check the Documents and Local AppData locations, migrate the first existing directory, and disable startup update checks in its settings. Both manifests create missing custom_properties.ini and playtime.dat files, update persisted paths, and attempt to copy settings and custom properties before uninstall.
Merge Risk: Low · up to a0d11
Migration from an existing data directory could, in a rare disk-full case, delete the source data after an incomplete copy. Migrated settings with indented update-check entries may also keep update checks enabled. Both are narrow edge cases, so the change is mergeable with awareness.
Pre-merge checks: 4
Check name
Status
Explanation
Title check
The title "duckstation(-preview): Modernise manifest" names the affected manifests (DuckStation and DuckStation Preview) and the general nature of the change. The changeset does modernise both manifes…
Description check
The description follows the template. It gives a clear summary of each change, including the new version format, shortcut move, preview binary rename, pre_install migration, persist changes, pre_unins…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Title check
Explanation
The title "duckstation(-preview): Modernise manifest" names the affected manifests (DuckStation and DuckStation Preview) and the general nature of the change. The changeset does modernise both manifests: it moves shortcut creation to the shortcuts field, updates the version format, and revises the install, uninstall, and persist logic. The title is broad, so it does not name the main specific change (the version format or shortcut move), but it refers to a real part of the change and is not misleading.
Full details: Description check
Explanation
The description follows the template. It gives a clear summary of each change, including the new version format, shortcut move, preview binary rename, pre_install migration, persist changes, pre_uninstall and post_uninstall updates, checkver regex, and the ARM64 URL fix. It keeps the contributing guide checkbox. The template's 'Closes #XXXX' or 'Relates to #XXXX' line is missing, so the linked issue is not stated. The author also checked the contributing guide box, and the note about #1251 gives context.
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Review info
Run configuration
Source mode: Auto
Repository: Unavailable
Branch: Unavailable
File: No configuration file from this repository applied
Commit: Unavailable
Layers: Organization UI
Review profile: CHILL
Plan: Advanced
Run ID: 6348bf69-6079-4789-9daa-6c92d43630b9
Commits
Reviewing files that changed from the base of the PR and between 59e9f4e and d0d4e56.
Files selected for processing: 2
bucket/duckstation-preview.json
bucket/duckstation.json
Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 0 remain after this review.
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Review info
Run configuration
Source mode: Auto
Repository: Unavailable
Branch: Unavailable
File: No configuration file from this repository applied
Commit: Unavailable
Layers: Organization UI
Review profile: CHILL
Plan: Advanced
Run ID: 8cc60121-25b1-42f6-8ed7-c24ce4d57e83
Commits
Reviewing files that changed from the base of the PR and between d0d4e56 and a0d1123.
Files selected for processing: 2
bucket/duckstation-preview.json
bucket/duckstation.json
Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr contains a plethora of changes:
YYYYMMDDHHMMSS-<commit>with no unnecessarygprefix. this is due to the fact that multiple releases can be made in a single day and currently scoop might or might not detect it being a newer version. adding time fixes this.shortcutsfield instead ofpost_installscripts. (the reason for the existing script is due to bugs found in [Bug]: Duckstation Fails to Open in Current Folder - Failed to open game list cache #1251, however, this is no longer an issue and so we can go back to using regular shortcut creation).-previewadded to thebinname to allow side-by-side installs with the stable release.pre_installmigration script now accounts for a new location on user appdata. in addition, we now disable check for updates on migrated/fresh installs and fixed an issue that caused the first-run wizard to not show.lastly, to support new persist items, we create two files if they don't already exist
post_installscript now only create the portable.txt file.dumpfolder as that is no longer used and added:gameicons,patches,resources\themes,subchannels,videos,watches,custom_properties.ini&playtime.dat(all verified to have, or have the potential to have user data that one would want version to version)pre_uninstallscript now savescustom_properties.ini(newly added to persist), and no longer errors if a file is missing.post_uninstallscript has been removed as its no longer necessary with the shortcuts change.checkver, it has had its regex updated to capture the release time to build the new version format.autoupdate, the arm64 URL casing is fixed (duckstation.json only).