You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
eden(-nightly): Disable in-app update with pre_install script - #1859
This PR does the following to both 'eden.json' and 'eden-nightly.json' manifests:
Slight edit to notes url to remove anchor (as it's unnecessary)
Modifies the pre_install script to add a section to disable in-app updates as that is set to enabled by default (potentially breaking scoop install if updated)
Refreshed the Windows nightly downloads for 64-bit and ARM64.
The QuickStart link no longer jumps directly to the steps section.
Update checks are disabled in the saved configuration, including during first-time setup when no existing configuration is found.
Walkthrough
Both Eden manifests remove the #steps fragment from the QuickStart URL. Their pre-install scripts disable both update-check settings in migrated configuration files or create configuration files with those settings disabled. The nightly manifest also updates its version and Windows download details.
The pre-install scripts set both update-check settings to false in migrated configuration files. If the old AppData directory is absent, they create configuration files with both settings disabled.
The QuickStart URL no longer includes the #steps fragment.
Merge Risk: Low · up to ed231
The manifests now disable Eden's in-app updates for new installs and migrated profiles. Existing Scoop installations and migrated profiles that lack a config file or the update-check entries can keep update checks enabled. This is a small gap and does not block merging, but it is worth closing or documenting.
Pre-merge checks: 4
Check name
Status
Explanation
Title check
The title names the two manifests (eden and eden-nightly) and the main change, disabling in-app update through the pre_install script. The changeset matches this: both manifests gain a pre_install sec…
Description check
The description follows the template's general structure. It gives a summary of the changes, lists the two manifest edits (notes URL anchor removal and the pre_install update-disable section), and kee…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Title check
Explanation
The title names the two manifests (eden and eden-nightly) and the main change, disabling in-app update through the pre_install script. The changeset matches this: both manifests gain a pre_install section that disables both update-check settings in the config, and the notes URL loses its #steps fragment. The title does not mention the notes URL edit, which is a minor change.
Full details: Description check
Explanation
The description follows the template's general structure. It gives a summary of the changes, lists the two manifest edits (notes URL anchor removal and the pre_install update-disable section), and keeps the contributing guide checkbox ticked. It does not include a 'Closes #XXXX' or 'Relates to #XXXX' line, so no linked issue is stated. The template also asks for a linked issue, and the author does not provide one.
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
Review info
Run configuration
Source mode: Auto
Repository: Unavailable
Branch: Unavailable
File: No configuration file from this repository applied
Commit: Unavailable
Layers: Organization UI
Review profile: CHILL
Plan: Advanced
Run ID: 84777b62-5fe0-4dcb-9669-6fe6ae508f9b
Commits
Reviewing files that changed from the base of the PR and between 62d6b8c and c0ec4a4.
Files selected for processing: 2
bucket/eden-nightly.json
bucket/eden.json
Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Review info
Run configuration
Source mode: Auto
Repository: Unavailable
Branch: Unavailable
File: No configuration file from this repository applied
Commit: Unavailable
Layers: Organization UI
Review profile: CHILL
Plan: Advanced
Run ID: ef4194b5-53fa-46b2-871d-b72730b23faa
Commits
Reviewing files that changed from the base of the PR and between c0ec4a4 and ed231fd.
Files selected for processing: 2
bucket/eden-nightly.json
bucket/eden.json
Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does the following to both 'eden.json' and 'eden-nightly.json' manifests:
pre_installscript to add a section to disable in-app updates as that is set to enabled by default (potentially breaking scoop install if updated)