Skip to content

eden(-nightly): Disable in-app update with pre_install script - #1859

Merged
Calinou merged 1 commit into
ScoopInstaller:masterfrom
Mahir007:eden-manifest
Nov 17, 2026
Merged

Calinou merged 1 commit into
ScoopInstaller:masterfrom
Mahir007:eden-manifest

Conversation

@Mahir007

Copy link
Copy Markdown
Contributor

This PR does the following to both 'eden.json' and 'eden-nightly.json' manifests:

  • Slight edit to notes url to remove anchor (as it's unnecessary)
  • Modifies the pre_install script to add a section to disable in-app updates as that is set to enabled by default (potentially breaking scoop install if updated)

@coderabbitai

coderabbitai Bot commented Nov 15, 2026 •

Copy link
Copy Markdown

Explain Change →

Summary by CodeRabbit

  • Changes
    • Refreshed the Windows nightly downloads for 64-bit and ARM64.
    • The QuickStart link no longer jumps directly to the steps section.
    • Update checks are disabled in the saved configuration, including during first-time setup when no existing configuration is found.

Walkthrough

Both Eden manifests remove the #steps fragment from the QuickStart URL. Their pre-install scripts disable both update-check settings in migrated configuration files or create configuration files with those settings disabled. The nightly manifest also updates its version and Windows download details.

Changes

Eden manifest updates

Layer / File(s) Summary
Update nightly build metadata
bucket/eden-nightly.json
The nightly manifest version, 64-bit and ARM64 download URLs, and hashes are updated.
Disable update checks
bucket/eden-nightly.json, bucket/eden.json
The pre-install scripts set both update-check settings to false in migrated configuration files. If the old AppData directory is absent, they create configuration files with both settings disabled.
Update QuickStart URL
bucket/eden-nightly.json, bucket/eden.json
The QuickStart URL no longer includes the #steps fragment.
Merge Risk: Low · up to ed231

The manifests now disable Eden's in-app updates for new installs and migrated profiles. Existing Scoop installations and migrated profiles that lack a config file or the update-check entries can keep update checks enabled. This is a small gap and does not block merging, but it is worth closing or documenting.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title names the two manifests (eden and eden-nightly) and the main change, disabling in-app update through the pre_install script. The changeset matches this: both manifests gain a pre_install sec…
Description check Passed The description follows the template's general structure. It gives a summary of the changes, lists the two manifest edits (notes URL anchor removal and the pre_install update-disable section), and kee…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the two manifests (eden and eden-nightly) and the main change, disabling in-app update through the pre_install script. The changeset matches this: both manifests gain a pre_install section that disables both update-check settings in the config, and the notes URL loses its #steps fragment. The title does not mention the notes URL edit, which is a minor change.

Full details: Description check

Explanation

The description follows the template's general structure. It gives a summary of the changes, lists the two manifest edits (notes URL anchor removal and the pre_install update-disable section), and keeps the contributing guide checkbox ticked. It does not include a 'Closes #XXXX' or 'Relates to #XXXX' line, so no linked issue is stated. The template also asks for a linked issue, and the author does not provide one.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

Review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 84777b62-5fe0-4dcb-9669-6fe6ae508f9b
Commits

Reviewing files that changed from the base of the PR and between 62d6b8c and c0ec4a4.

Files selected for processing: 2

  • bucket/eden-nightly.json
  • bucket/eden.json

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.

Comment thread bucket/eden-nightly.json Resolved
Comment thread bucket/eden.json Resolved
@Mahir007

Copy link
Copy Markdown
Contributor Author

/verify

@github-actions

Copy link
Copy Markdown
Contributor

All changes look good.

Wait for review from human collaborators.

eden-nightly

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

eden

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Check the full log for details.

@Calinou Calinou added the enhancement New feature or request label Nov 16, 2026

@Calinou Calinou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: ef4194b5-53fa-46b2-871d-b72730b23faa
Commits

Reviewing files that changed from the base of the PR and between c0ec4a4 and ed231fd.

Files selected for processing: 2

  • bucket/eden-nightly.json
  • bucket/eden.json

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.

Comment thread bucket/eden-nightly.json Resolved
@Mahir007

Copy link
Copy Markdown
Contributor Author

/verify

@github-actions

Copy link
Copy Markdown
Contributor

All changes look good.

Wait for review from human collaborators.

eden-nightly

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

eden

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Check the full log for details.

@Mahir007

Copy link
Copy Markdown
Contributor Author

Updated to the latest nightly build.

@Calinou
Calinou merged commit cd0cf59 into ScoopInstaller:master Nov 17, 2026
3 checks passed
@Mahir007
Mahir007 deleted the eden-manifest branch November 17, 2026 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request review-needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants