Fix construction placement controls and ACE action compatibility - #5
Open
Etaselia wants to merge 1 commit into
Open
Fix construction placement controls and ACE action compatibility#5Etaselia wants to merge 1 commit into
Etaselia wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this is needed
Some CUP objects include a decorative ground plane or ground texture underneath the visible model. That plane is intended to sit below the terrain, but the current placement code treats its lowest edge as the bottom of the object. Since there is no way to lower the object or allow that part of the model to clip into the terrain, the visible object ends up floating above the ground. Manual height adjustment and optional ground clipping make it possible to place these objects as intended.
There is also a compatibility problem with current ACE interaction action-tree storage. The construction completion interaction can be recreated repeatedly, causing finished objects to spawn continuously. This quickly destroys frame rate and makes the construction system unusable. Reading the action tree through the current ACE API prevents the duplicate interaction while retaining a fallback for older ACE versions.
Summary
Placement controls
Alt + mouse wheel: adjust object height.T: toggle terrain-level and sea-level alignment.C: toggle ground clipping.The default alignment, clipping behavior, height step, and placement hint can be configured through CBA settings.
Validation
The final crate terrain-contact adjustment should also be checked on steep and uneven terrain during review.