-
Notifications
You must be signed in to change notification settings - Fork 0
Automated WCAG 2.1 AA a11y testing across all themes/modes #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
sjoerdbeentjes
wants to merge
16
commits into
main
Choose a base branch
from
feat/a11y-testing
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
3c6d008
Add a11y config and audit module to @surfnet/storybook-config
sjoerdbeentjes b3579f8
Wire WCAG 2.1 AA audit into React and Angular Storybooks
sjoerdbeentjes 8df0d62
Add test:a11y workspace script, Turbo task, and CI step
sjoerdbeentjes be9d189
Reorder storybook:serve before test:a11y in package scripts
sjoerdbeentjes f33ce38
Write a11y reports to git-ignored .a11y-report dir
sjoerdbeentjes dfb1ea7
Group a11y comment by component → theme → mode
sjoerdbeentjes bea7bd2
Split component and variation into h4/h5 in a11y comment
sjoerdbeentjes 6ac897c
Collapse theme-independent a11y findings to one per variation
sjoerdbeentjes 5a036a5
Add link-in-text-block WCAG ref (1.4.1) to a11y comment
sjoerdbeentjes 64fad1f
Move playwright dep from react to storybook-config, scope CI install …
sjoerdbeentjes 3344148
Stabilise a11y audit and trim comments
sjoerdbeentjes 549f126
Adopt @surfnet/curve-* package names; note headless run in a11y CI
sjoerdbeentjes 459f38f
Inline a11y-comment script call in CI, drop a11y:comment workspace sc…
sjoerdbeentjes c9cf3a0
Capture and embed a11y violation screenshots
sjoerdbeentjes 17f1859
Drop fixed width on a11y comment screenshots
sjoerdbeentjes bc7b4c3
Update playwright to 1.61.1
sjoerdbeentjes File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,31 +1,34 @@ | ||
| # dependencies | ||
| node_modules | ||
| .pnpm-store | ||
|
|
||
| # secrets | ||
| .env | ||
| .env.local | ||
|
|
||
| # build output | ||
| dist | ||
| storybook-static | ||
|
|
||
| # turbo | ||
| .turbo | ||
|
|
||
| # angular | ||
| .angular | ||
|
|
||
| # logs | ||
| *.log | ||
| npm-debug.log* | ||
| pnpm-debug.log* | ||
|
|
||
| # editor / os | ||
| .DS_Store | ||
| .vs | ||
| !.vscode | ||
| .vscode/* | ||
| !.vscode/extensions.json | ||
| !.vscode/mcp.json | ||
| .idea | ||
| # dependencies | ||
| node_modules | ||
| .pnpm-store | ||
|
|
||
| # secrets | ||
| .env | ||
| .env.local | ||
|
|
||
| # build output | ||
| dist | ||
| storybook-static | ||
|
|
||
| # accessibility audit reports | ||
| .a11y-report | ||
|
|
||
| # turbo | ||
| .turbo | ||
|
|
||
| # angular | ||
| .angular | ||
|
|
||
| # logs | ||
| *.log | ||
| npm-debug.log* | ||
| pnpm-debug.log* | ||
|
|
||
| # editor / os | ||
| .DS_Store | ||
| .vs | ||
| \!.vscode | ||
| .vscode/* | ||
| \!.vscode/extensions.json | ||
| \!.vscode/mcp.json | ||
| .idea |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| import type { TestRunnerConfig } from '@storybook/test-runner'; | ||
|
|
||
| import { runStoryA11yAudit } from '@surfnet/curve-storybook-config/test-runner'; | ||
|
|
||
| // Delegate to the shared audit so React and Angular stay in lockstep. | ||
| const config: TestRunnerConfig = { | ||
| async postVisit(page, context) { | ||
| await runStoryA11yAudit(page, context); | ||
| }, | ||
| }; | ||
|
|
||
| export default config; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| import type { TestRunnerConfig } from '@storybook/test-runner'; | ||
|
|
||
| import { runStoryA11yAudit } from '@surfnet/curve-storybook-config/test-runner'; | ||
|
|
||
| // Delegate to the shared audit so React and Angular stay in lockstep. | ||
| const config: TestRunnerConfig = { | ||
| async postVisit(page, context) { | ||
| await runStoryA11yAudit(page, context); | ||
| }, | ||
| }; | ||
|
|
||
| export default config; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hoe is de performance? Ik zou verwachten dat we in een CI-stap een headless browser gebruiken.