Make dark/light mode a one-press toggle#108
Merged
Merged
Conversation
Replace the two-item Mode dropdown in the shared Storybook toolbar with a single-press toggle button, registered as a manager tool. It reads/writes the existing `mode` global (still reflected onto <html> by themeSwitcher) and shows Storybook's own sun/moon icon plus a Light/Dark label. Closes #92
sjoerdbeentjes
force-pushed
the
refactor/mode-control
branch
from
July 14, 2026 14:28
b3ceb27 to
5712435
Compare
sjoerdbeentjes
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the two-item Mode dropdown in the shared Storybook toolbar with a single-press toggle button.
modeglobal (still reflected onto<html>bythemeSwitcher), so behaviour is unchanged, only the control.SunIcon/MoonIconplus a Light/Dark label. Sits in the left toolbar group with the other toggles (grid, measure, outline).modeglobal no longer has aglobalType(no dropdown); it stays driven byinitialGlobalsand carried across frameworks.Shared config, so it applies to both the React and Angular Storybooks. Verified in the running React Storybook: light -> dark -> light, icon/label swap, story canvas follows.
Closes #92