Repository navigation
Feature/issue 11 add date to subtransactions - #12
Merged
Merged
Conversation
The root cause is that _call_with_retries uses None as its failure signal, but some YNAB API endpoints (like update_transactions) legitimately return None on success — it's a 204 No Content equivalent. The fix is a sentinel value to distinguish "failed" from "succeeded but returned None".
An uncleared transaction is often a transaction that was not posted on a credit card. Sometimes the value of the transaction can change until cleared, and that's why I'm opting to always skip uncleared transactions. A regression test has been added to account for that. BREAKING CHANGE: Since this modifies the behaviour of the script, making it skip transactions that would otherwise not be skipped, this should be treated as a breaking change.
Closes #2. Batches the account ID from name lookups into a single fetch call, whereas before it used two.
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #11 and #2.
Also:
An uncleared transaction is often a transaction that was not posted on a credit card. Sometimes the value of the transaction can change until cleared, and that's why I'm opting to always skip uncleared transactions. A regression test has been added to account for that.
BREAKING CHANGE: Since this modifies the behaviour of the script, making it skip transactions that would otherwise not be skipped, this should be treated as a breaking change.