fix(flag, icon): resolve empty value returned by getComputedStyle on Chromium 151+ - #1311
Merged
Merged
Conversation
Deploying refinitiv-ui with
|
| Latest commit: |
d1810a9
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d50346e7.refinitiv-ui.pages.dev |
| Branch Preview URL: | https://fix-chromium-151-get-compute-ocdp.refinitiv-ui.pages.dev |
|
Size Change: +447 B (+0.03%) Total Size: 1.56 MB
ℹ️ View Unchanged
|
wattachai-lseg
marked this pull request as ready for review
August 11, 2026 08:51
wattachai-lseg
force-pushed
the
fix/chromium-151-get-computed-style-v6
branch
from
August 11, 2026 09:31
f59f9f8 to
d1810a9
Compare
|
Sarin-Udompanish
approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Chromium only issue: starting from version 151, when Icon is slotted into an unregistered custom element,
getComputedStyle()will always return empty string as a style value. It needs to wait for the registration of the parent custom element first. In practice, this happens when Icon class and its style are imported before the parent's ones as following:Additionally, this PR includes the following change:
Checklist