Repository navigation
Conversation
Having serve depend on update-browserslist can cause a race condition when you're using npx nx run-many because one process (update-browserslist) is changing packages while others (serve-es, serve-fr, serve web-component) are compiling from them. Also, having serve depend on update-browerslist makes serve much slower on my Windows machine, because the latter can easily take a minute. We want to automate it, yes, but Del and I agree that on install is a better time and place to automate it than on serve, and it's plently often enough to satisfy our requirements.
joanise
added this pull request to stack #621
October 7, 2026 20:50
|
Review changes with Changed Files
|
Contributor
|
deltork
requested changes
Oct 7, 2026
deltork
left a comment
deltork
left a comment
Collaborator
There was a problem hiding this comment.
I think a husky post-merge hook might be useful. Update happens after every merge
Member
Author
|
I don't see post-merge hooks in the Husky documentation, but I'm also not sure I really want that... |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Goal?
Having serve depend on update-browserslist can cause a race condition when you're using npx nx run-many because one process (update-browserslist) is changing packages while others (serve-es, serve-fr, serve web-component) are compiling from them.
Also, having serve depend on update-browerslist makes serve much slower on my Windows machine, because the latter can easily take a minute.
We want to automate it, yes, but Del and I agree that on install is a better time and place to automate it than on serve, and it's plently often enough to satisfy our requirements.
Fixes?
race condition in run-many, delay each time I serve
Feedback sought?
Mostly making sure it works on MacOS and solves the problem @marctessier observed testing #620.
Priority?
low
Tests added?
well tested by CI
How to test?
Confidence?
high
Version change?
nope