Repository navigation
Release workflow: use GITHUB_TOKEN and require the version to be bumped in a PR - #166
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 3.10.0 release run (40972439351) failed at its first step.
actions/create-github-app-tokencould not read theAPP_PRIVATE_KEYsecret (Invalid keyData), so nothing was published.This PR changes the Release workflow:
token:input on checkout are removed, so checkout, the GitHub release and the tag all use the built-inGITHUB_TOKEN. The job keepscontents: writeandid-token: write, the second for RubyGems trusted publishing.lib/versiondoesn't match the requested version. The release process is now:lib/versionin a PR.master already has
lib/version= 3.10.0, so once this merges, 3.10.0 can be released by running the workflow again.APP_ID,APP_PRIVATE_KEYandRUBY_GEMS_API_KEYare no longer used by this workflow and can be removed once a release has worked.