Repository navigation
test: add widget test suite for core flows + GitHub Actions CI - #237
Merged
Merged
Conversation
- 12 widget tests covering: first-target focus, onFinish/overlay removal, skip (close and next-on-false), target tap + onClickTarget, rapid synchronous next() (#175, #183), rapid overlay double-tap (#175, #183), pulse not delaying next() (#235), missing-target skip (#218, #223, #199), all-missing finish, previous(), initialFocus. - pumpAndSettle is avoided on purpose (pulse loops forever). - add GitHub Actions CI (analyze + test) so tests run on every push/PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
First real test suite for
tutorial_coach_mark(the existingtest/tutorial_coach_mark_test.dartwas empty), plus a GitHub Actions CI so tests run on every push/PR.Tests (12 widget tests — ✅ all passing in CI)
onFinish+ overlay removalonSkipand closes;onSkip => falseadvances insteadonClickTargetand advancesnext()calls only advance one step (guard set before await); rapid double-tap on the overlay only advances one stepnext()advances within ~900ms even with a 10s pulse (unfocus no longer waits for the pulse loop)previous()returns to the previous target;initialFocusstarts at the given indexNotes:
pumpAndSettleis intentionally avoided — the pulse animation loops forever.pump(Duration.zero)is required instead ofpump()for the package'sFuture.delayed(Duration.zero)timers.awaitboundary needs its own frame).CI
.github/workflows/ci.yml:flutter analyze --no-fatal-infos+flutter testonubuntu-latestfor every push/PR. (--no-fatal-infosbecause the lib still has pre-existingwithOpacitydeprecation infos that must not fail the build while old Flutter is supported.)Verification status
dart analyze test/— 0 issuesflutter test— 12/12 passing (GitHub Actions CI)