Skip to content

includes: fix missing lw_malloc header - #774

Closed
nicolas-bouton wants to merge 1 commit into
RRZE-HPC:masterfrom
SiPearl:nb/fix-missing-lw_malloc-header
Closed

nicolas-bouton wants to merge 1 commit into
RRZE-HPC:masterfrom
SiPearl:nb/fix-missing-lw_malloc-header

Conversation

@nicolas-bouton

Copy link
Copy Markdown
Contributor

No description provided.

Signed-off-by: Nicolas Bouton <nicolas.bouton@sipearl.com>
@TomTheBear

Copy link
Copy Markdown
Member

Not sure why the lw_alloc.h should be required in the main header likwid.h.

@nicolas-bouton

Copy link
Copy Markdown
Contributor Author

First, I apologize for the lack of information about this patch.

The issue I encountered during compilation of the Fortran interface concerned the implicit declaration of the function lw_malloc() in the likwid_markerwritefile_() function in src/likwid_f90_interface.c.

You resolved this issue in commit 55575b4 by including the lw_alloc.h header in src/likwid_f90_interface.c instead of the main header, likwid.h.

When I created this patch, I chose to include lw_alloc.h in the main header file because src/likwid_f90_interface.c includes only the main header while using other functions, such as those provided by the LIKWID marker API.

Could you please help me understand the purpose of the main header, likwid.h, so I can avoid similar confusion in the future?

@TomTheBear

Copy link
Copy Markdown
Member

When installing LIKWID, it copies only likwid.h and likwid-marker.h to the include folder. If you add lw_alloc.h to likwid.h, it needs to be installed as well. We had that with the bstrlib.h for some time and I was not happy with it.

@nicolas-bouton

Copy link
Copy Markdown
Contributor Author

Thanks for the explanation!

I am closing the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants