Uriel assignment05 - #29
Open
urielguerrero07 wants to merge 17 commits into
Open
Conversation
Complete warm-up 1 clean
Assignment 02: ALU implementation and testbench
Assignment_03_Completed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey Umer
Quick update on Assignment 05. I already pushed it, made a new branch
uriel-assignment05and opened a pull request so you can review when you have time.I added support for the branch and jump instructions: BEQ, BNE, BLT, BGE, BLTU, BGEU, JAL and JALR. I followed the static branch prediction approach the professor suggested (assume branches as not taken, flush the pipeline if they turn out taken, jumps always taken).
The main changes were:
Everything compiles and sbt test passes.
On the testbench side I did some basic test cases for the branches and jumps, but to be honest I'm not super confident with that part since I'm still getting used to the RISC-V encoding side of things. If you could review the test cases and maybe add more coverage I'd really appreciate it, you handle that part better than me.
Please check the PR when you can. I pushed this now to help you out and not put extra load on you so we can present before Friday since I can't make it that day.
Thanks bro