Repository navigation
fix(ci): pin reviewed native eval diagnostics - #326
Merged
mrizzi merged 1 commit intoOct 6, 2026
Merged
Conversation
Implements TC-6726 Assisted-by: Claude Code
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates the trusted native eval workflow to consume the reviewed immutable PR #299 commit containing safer native runner diagnostics, improving failure visibility without changing evaluation behavior or claiming to fix the underlying native failure. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey - I've reviewed your changes and they look great!
Sourcery assessment
Needs a human reviewer. This changes which native evaluation code the CI workflow executes, so a wrong or compromised pinned commit could run unintended code with the workflow's available permissions and expose CI data. Reverting restores the previous pin for future runs, but any credentials or data exposed by an already-run job would not be recoverable by the revert.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira
TC-6726
Change
Update only
NATIVE_EVAL_SOURCE_SHAin the trusted main workflow to the reviewed immutable PR #299 commitc7ca8495f1a83c51d191f55e391b17c5b29e97da.The difference from the previous pin is limited to native runner diagnostics and their regression coverage. No native eval suite files are added to main.
Why
Run 37471650779 failed with an incomplete result and no assertion outcomes. Its private execution/scoring logs were unavailable, so the exact cause remains unresolved.
The new safe artifact adds allowlisted phase/category names and integer phase exit codes. Raw stderr, transcripts and credentials remain private. Error categories are advisory hints from the first 64 KiB of phase stderr; they are not proof of a root cause or grading results. Judge failures can surface as
summary/invalid-summary.Cases, assertions, grading, credential isolation and CI permissions remain unchanged.
Validation
git diff --checkpassed.Next step
After human review and merge, rerun the PR #299 Eval PR trigger (run 37483925429), which creates a new consumer using the updated main pin. Do not rerun the old Eval PR Run consumer: it retains its original main revision. Inspect the new safe diagnostic artifact, then fix the evidenced native failure if it persists.
The obsolete old-pin consumer from the diagnostic source push was cancelled to avoid redundant model execution. This PR improves failure visibility; it does not claim the original native eval failure is fixed.
Summary by Sourcery
Pin the native evaluation workflow to the reviewed diagnostics revision.
Enhancements:
CI: