Repository navigation
Version assets by modification time - #50
Merged
Merged
Conversation
Add an asset() Twig helper that appends a file's mtime as a cache-busting query and use it for the CSS and JS links across the templates, in place of the hand-maintained version strings. Also drop the redundant inline @font-face blocks from the pixel-font page templates, which the shared stylesheet already defines.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces hand-maintained
?v=cache-busting strings on CSS and JS assets with anasset()Twig helper that versions each file by its modification time.asset()toTemplateUtil.php: it appends?v=<mtime>for a given asset path, and falls back to the unversioned path if the file is missing (so a bad path still loads).<link>/<script>?v=...reference across the templates to{{ asset('...') }}.@font-faceblocks from the four pixel-font page templates (the font is defined once inpokecrystal-pages.css).Assets now re-fetch automatically whenever their contents change, instead of relying on someone remembering to bump a version string.
Testing
php -lpasses onTemplateUtil.php. Loaded every page and confirmed the CSS/JS still resolve. Rendering is unchanged.