Repoint the mle.md download link to data-lectures - #61
Merged
Conversation
`mle.md:132` linked the fp.dta download at python.quantecon.org/_static/lecture_specific/mle/fp.dta — an asset served by lecture-python.myst's published site, not by this repo. That file is being migrated to QuantEcon/data-lectures and will be deleted from lecture-python.myst once its repoint publishes, at which point this link 404s. This repo runs a daily sphinx linkcheck, so it would go red within 24 hours of that publish. Repointing now closes the window. The bytes are identical — the migrated copy, the published-site copy and the archived copy this lecture's code cell reads all hash to de99b9c0de6fb08cb732e306971ba87a308c5c4ef8ca3ae23fbbb50eabdecd8d — so nothing a reader downloads changes. The link also named `mle/fp.dta` inline, a path that does not exist in data-lectures' flat published tree, so the filename in the sentence is corrected alongside the href. NOT changed: the code read at mle.md:139, which fetches the archived QuantEcon/lecture-python blob. That URL still resolves (archived repos serve raw content indefinitely) and is unaffected by this migration. Consolidating it onto data-lectures would be a sensible follow-up, but it is a change to what this lecture executes and is left as the maintainers' call. See QuantEcon/data-lectures#79 and QuantEcon/workspace-lectures#39. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
✅ Deploy Preview for timely-seahorse-68815c ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull request overview
This PR updates the fp.dta dataset download link in the MLE lecture to point to the new canonical hosting location in QuantEcon/data-lectures, preventing an imminent broken link once the old lecture-python.myst asset is removed.
Changes:
- Repoint
fp.dtadownload URL frompython.quantecon.org/_static/...tohttps://github.com/QuantEcon/data-lectures/raw/main/lectures/fp.dta. - Update the inline dataset name from
mle/fp.dtatofp.dtato match the new hosting layout.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lectures/mle.md:132links thefp.dtadownload athttps://python.quantecon.org/_static/lecture_specific/mle/fp.dta— an asset served by lecture-python.myst's published site, not by this repo.That file is being migrated to
QuantEcon/data-lectures(landed in QuantEcon/data-lectures#79) and will be deleted fromlecture-python.mystonce its repoint publishes, at which point this link 404s. This repo runslinkcheck.ymloncron: '0 12 * * *'— daily — so it would go red within 24 hours of that publish, in a repo that had no part in the migration. Repointing now closes the window rather than waiting for the alarm.Nothing a reader downloads changes. The migrated copy, the published-site copy, and the archived copy this lecture's own code cell reads all hash to
de99b9c0de6fb08cb732e306971ba87a308c5c4ef8ca3ae23fbbb50eabdecd8d— verified by fetching all three today.The link also named
mle/fp.dtainline in the sentence, a path that does not exist in data-lectures' flat published tree, so the filename is corrected alongside the href.Not changed, deliberately
The code read at
mle.md:139fetches the archivedQuantEcon/lecture-pythonblob:That URL still resolves — archived repos serve raw content indefinitely — and is unaffected by this migration, which touches
lecture-python.myst, a different repo. Consolidating it ontodata-lecturesalongside the link above would be a sensible follow-up: it would retire a dependency on an archived repo, and the bytes are identical so the lecture's output would not move. But it changes what this lecture executes, so it is left as the maintainers' call rather than folded into a link fix.The same applies to
lectures/ols.md, whose fiveread_statacalls also point at the archived repo.Context
This is one PR of a cross-repo wave. Data landed in QuantEcon/data-lectures#79;
lecture-python.mystrepoints in QuantEcon/lecture-python.myst#1034. Plan and tracking: QuantEcon/workspace-lectures#39.🤖 Generated with Claude Code