Update PyPSA dependency >= V1 - #762
Conversation
|
The biggest concern I have is around changing the unit commitment implementation. The default attr isn't available as part of pypsa v1 so I borrowed the implementation mostly from the pypsa-eur implementation. Open to discussion about the change of method and addition of |
for more information, see https://pre-commit.ci
ktehranchi
left a comment
There was a problem hiding this comment.
A few things:
In PyPSA-USA we always merge new developments to the develop branch first before moving to master. We make releases from develop -> master when there are large feature bumps. So i would change this to merge into develop.
RE: Unit-committment. I'm fine to move toward the data-source and method used in pypsa-eur for UC... we currently take it from the public version of the wecc ads, matched on the unit, then fill missing data with the averages of the WECC dataset... but would be fine to use a flat csv to fill any missing data... But i think this can be a different PR.
|
Target branch has been changed. Can you clarify the preference for how to do the UC in a different PR? |
|
Thanks for the work on this, @apigott! Quick question, have you run the sector network with this, or just the electrical network? If you haven't actually run the sector network, I can run it over the next couple of days to make sure nothing broke with sector studies. |
|
@trevorb1 I haven't had a chance to test the sectoral coupling |
|
@apigott Sorry, this PR slipped my mind! Il try to do a test of it this weekend! |
Closes #701
Changes proposed in this Pull Request
Updates PyPSA-USA to track changes made in PyPSA V1
Checklist
envs/environment.yaml.config.default.yaml.doc/configtables/*.csv.