Quote procname and user variables with backticks in callproc#789
Draft
Copilot wants to merge 4 commits into
Draft
Quote procname and user variables with backticks in callproc#789Copilot wants to merge 4 commits into
Copilot wants to merge 4 commits into
Conversation
Copilot
AI
changed the title
[WIP] Port changes from PR #1225 to quote procname in callproc
Quote procname and user variables with backticks in callproc
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
callprocpassed the procedure name and user variable names unquoted into SQL, making it unsafe for names containing reserved words or special characters.Changes
_backquote_escape(s)— new helper that doubles backticks in abytesvalue to safely embed it as a backtick-quoted identifiercallproc— escapesprocnameand wraps it in backticks in both theCALLstatement and the@_procname_n`` user variables used for args/OUT paramsPorts PyMySQL/PyMySQL#1225.