feat(surveys): add copyable participant link (Issue 1458) - #1469
Merged
Merged
Conversation
Closes a gap noted in code review — the existing catch block already handles navigator.clipboard being absent (insecure context / older browsers), but no test exercised that path.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SurveyCopyLinkButtonthat copies the absolute participant URL (${window.location.origin}/surveys/${slug}) vianavigator.clipboard.writeTextSurveyBuilderScreen's header and each row ofSurveyAdminListScreenlink copiedon success,couldn't copy — try againon failureCloses #1458
Test plan
make agent-frontend-lintmake agent-frontend-typecheckmake agent-frontend-test(1285 passed)SurveyAdminListScreen.test.tsxNote:
make agent-ci's backend suite fails on this sandbox (test_sse.py::TestSseStreamAuth::*,test_rsvp_capacity_race.py) due to documented SQLite limitations (nopg_notify, no real row-locking under concurrent threads) — unrelated to this frontend-only change.