Skip to content

ci: remove redundant version bump write permission - #272

Merged
marandaneto merged 1 commit into
mainfrom
ci/remove-redundant-release-permissions-20260910110030
Sep 10, 2026
Merged

ci: remove redundant version bump write permission#272
marandaneto merged 1 commit into
mainfrom
ci/remove-redundant-release-permissions-20260910110030

Conversation

@marandaneto

Copy link
Copy Markdown
Member

💡 Motivation and Context

The version-bump job grants the built-in GITHUB_TOKEN repository write access even though its repository writes use a separate GitHub App token.

Lower version-bump to contents: read. Preserve the App-authenticated checkout and all App-token commit, tag and release operations. No authentication input or App permission changes.

Read-only workflow inheritance remains allowed. This reduces the built-in token's permissions, not the job's separate App-token authority or build/publish exposure. No package release or changeset is needed.

💚 How did you test it?

  • Checked every repository-write operation in the affected job and traced it to the App token, including the pinned action contracts.
  • Compared parsed YAML with the baseline and verified that only the intended permission keys changed. Triggers, steps, dependencies, secrets and token wiring are unchanged.
  • actionlint -shellcheck= -pyflakes= and git diff --check passed. Existing shell-lint diagnostics were checked against the baseline and left unchanged.
  • Reviewed the final branch diff. No live release or SDK tests were run for this permission-only change.

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes. No SDK tests apply to this permission-only change.
  • I updated the docs if needed. No documentation change is needed.
  • No breaking change or entry added to the changelog.

If releasing new changes

No package release or changeset is needed.

🤖 Agent context

Autonomy: Human-driven (agent-assisted)

Implemented with Pi and delegate agents using file tools, Git, GitHub CLI, Python/PyYAML and actionlint. The parent agent reviewed the final diff. Work was performed in a dedicated worktree. Autoreview was skipped because all changes are GitHub workflow permission administration. No session transcript was published. Human review is required.

@marandaneto marandaneto self-assigned this Sep 10, 2026
@github-actions

Copy link
Copy Markdown

posthog-ruby Compliance Report

Date: 2026-09-10 09:09:29 UTC
Duration: 98192ms

✅ All Tests Passed!

46/46 tests passed


Capture Tests

29/29 tests passed

View Details
Test Status Duration
Format Validation.Event Has Required Fields 9ms
Format Validation.Event Has Uuid 106ms
Format Validation.Event Has Lib Properties 108ms
Format Validation.Distinct Id Is String 106ms
Format Validation.Token Is Present 105ms
Format Validation.Custom Properties Preserved 106ms
Format Validation.Event Has Timestamp 107ms
Retry Behavior.Retries On 503 5414ms
Retry Behavior.Does Not Retry On 400 2108ms
Retry Behavior.Does Not Retry On 401 2108ms
Retry Behavior.Respects Retry After Header 8115ms
Retry Behavior.Implements Backoff 15419ms
Retry Behavior.Retries On 500 5213ms
Retry Behavior.Retries On 502 5212ms
Retry Behavior.Retries On 504 5211ms
Retry Behavior.Max Retries Respected 15522ms
Deduplication.Generates Unique Uuids 111ms
Deduplication.Preserves Uuid On Retry 5211ms
Deduplication.Preserves Uuid And Timestamp On Retry 10411ms
Deduplication.Preserves Uuid And Timestamp On Batch Retry 5216ms
Deduplication.No Duplicate Events In Batch 111ms
Deduplication.Different Events Have Different Uuids 107ms
Compression.Sends Gzip When Enabled 106ms
Batch Format.Uses Proper Batch Structure 106ms
Batch Format.Flush With No Events Sends Nothing 4ms
Batch Format.Multiple Events Batched Together 110ms
Error Handling.Does Not Retry On 403 2108ms
Error Handling.Does Not Retry On 413 2109ms
Error Handling.Retries On 408 5207ms

Feature_Flags Tests

17/17 tests passed

View Details
Test Status Duration
Request Payload.Request With Person Properties Device Id 107ms
Request Payload.Flags Request Uses V2 Query Param 107ms
Request Payload.Flags Request Hits Flags Path Not Decide 106ms
Request Payload.Flags Request Omits Authorization Header 108ms
Request Payload.Token In Flags Body Matches Init 108ms
Request Payload.Groups Round Trip 108ms
Request Payload.Groups Default To Empty Object 107ms
Request Payload.Disable Geoip False Propagates As Geoip Disable False 107ms
Request Payload.Disable Geoip Omitted Defaults To False 107ms
Request Payload.Flag Keys To Evaluate Contains Only Requested Key 107ms
Request Lifecycle.No Flags Request On Init Alone 4ms
Request Lifecycle.No Flags Request On Normal Capture 105ms
Request Lifecycle.Two Flag Calls Produce Two Remote Requests 110ms
Request Lifecycle.Mock Response Value Is Returned To Caller 107ms
Retry Behavior.Retries Flags On 502 249ms
Retry Behavior.Retries Flags On 504 258ms
Side Effect Events.Get Feature Flag Captures Feature Flag Called Event 109ms

@marandaneto
marandaneto marked this pull request as ready for review September 10, 2026 09:17
@marandaneto
marandaneto requested a review from a team as a code owner September 10, 2026 09:17
@greptile-apps

greptile-apps Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Reviews (1): Last reviewed commit: "ci: remove redundant release contents pe..." | Re-trigger Greptile

@marandaneto
marandaneto merged commit b4f9029 into main Sep 10, 2026
22 checks passed
@marandaneto
marandaneto deleted the ci/remove-redundant-release-permissions-20260910110030 branch September 10, 2026 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants