Skip to content

Normalize HappyForms native form IDs - #1367

Open
danieliser wants to merge 1 commit into
feature/fluent-submission-normalizationfrom
feature/happyforms-form-id-normalization
Open

danieliser wants to merge 1 commit into
feature/fluent-submission-normalizationfrom
feature/happyforms-form-id-normalization

Conversation

@danieliser

Copy link
Copy Markdown
Member

Summary

  • read HappyForms 1.26.15's authoritative uppercase ID form key
  • retain a defensive lowercase fallback for compatible integrations
  • reject malformed/missing form identities before normalized dispatch
  • add regression coverage for one dispatch per valid native form ID

This is the minimal Core correctness dependency discovered by the real-provider smoke for PopupMaker/Pro#145. Pro does not guess or emit a second submission.

Tests

  • vendor/bin/phpunit --configuration tests/php/phpunit.xml --filter FormSubmissionPhases_Test (17 tests, 62 assertions)
  • focused PHPStan and PHPCS clean
  • real HappyForms 1.26.15 hook smoke continues in the stacked Pro PR

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@coderabbitai

coderabbitai Bot commented Aug 15, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (1)
  • develop

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 95ab53ba-cfd6-466b-bfc0-3a96031bd9eb

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@danieliser

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant