Round-2 verification fixes: nested SVAR errors, contract hardening, population-claims sweep#17
Merged
Merged
Conversation
MaxGhenis
force-pushed
the
round2-verification-fixes
branch
from
July 16, 2026 23:43
0c37bdb to
96543e1
Compare
…opulation-claims sweep
From Sol's post-merge verification pass over the night's merged work.
Not-resolved items closed: the real multi-parameter Policy constructor
now runs in the nightly contract job; boe_var contracts fail (not skip)
under MACROMOD_REQUIRE_PE=1; SVAR shock names are pinned semantically
(a demand/supply label swap now fails the contract test); the static-
catalogue shape test uses resolve=False so the fast suite never pays
the PE import; hosted population scoring is stated consistently across
the homepage card, pe page, connect page, and README roadmap.
New findings closed: 'macromod summary' errors actionably when a
configured fallback checkout has no parseable results (the round-1 fix
only caught the top-level error shape), and partial section errors
print visibly; the integration README dev command now installs the
[models] extra its own examples need, with OG-UK as the optional add;
modal_app's stale hardcoded-path claim corrected; wiring tests pin the
closure tri-state through the CLI and the []/{}-reform clean errors;
the remote inventory asserts all ten tools.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
MaxGhenis
force-pushed
the
round2-verification-fixes
branch
from
July 16, 2026 23:43
96543e1 to
4cd7a4c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Round-2 (verification-pass) fixes from Sol's post-merge audit of tonight's merged work — five prior findings it judged not-fully-resolved, plus two new blockers and four nits it found in the fixes themselves.
Prior findings closed for real:
Policyconstruction now runs somewhere: the nightly contract job includestest_og_build_policy_real(the fast guard necessarily mocks it).MACROMOD_REQUIRE_PE=1.resolve=False, so the fast suite never pays the ~20s PE import.New findings closed:
macromod summarywithMACROMOD_BOE_VAR_REPOpointing at a directory without parseable results now raises an actionable error (the round-1 fix only caught the top-level error shape — empty headings + exit 0 were reproducible one level down); partial section errors print visibly. Regression test included.[models]extra its own examples require, with OG-UK as the documented optional add.modal_app.py's stale claim that core hardcodes a personal path is corrected.--investment-closuretri-state through the CLI (omitted →None→ per-variable default) and the[]/{}reform clean-error paths; the remote smoke inventory asserts all ten tools.Fast suite: 50 passed / 38 skipped.
🤖 Generated with Claude Code