Skip to content

Cap the page at one shared max width; drop backfill shading - #7

Merged
kingsleydon merged 1 commit into
mainfrom
dashboard-page-max-width
Oct 29, 2026
Merged

kingsleydon merged 1 commit into
mainfrom
dashboard-page-max-width

Conversation

@kingsleydon

Copy link
Copy Markdown
Collaborator

Changes

  • Page width. The header row and main now share one max width, max-w-(--breakpoint-2xl) (Tailwind's --breakpoint-2xl = 96rem = 1536px), and are centered with mx-auto w-full. This follows the shadcn/ui site, which caps its container-wrapper / container with --breakpoint-2xl / max-w-screen-2xl (apps/v4/app/globals.css, components/site-header.tsx). The header border and background stay full-bleed. Every block keeps the dashboard-01 padding px-4 lg:px-6, so all content shares the same left and right edges. No element has its own width cap.
  • Backfill shading removed. The shaded backfilled days on the Users and VMs charts are gone, along with the "(recomputed)" table marker and the "Backfilled days are shaded" alert. The code and tests that only served them (backfillRanges, formatDayRange) are deleted. /api/data still has backfilled, its API and runtime tests are unchanged, and app/README.md explains it in one short paragraph.

Verification

  • bun run verify:app passes (typecheck, biome, 110 tests, build), and so does root bun run check.
  • align/measure.ts ran against a local production build seeded from live /api/data: 12 widths (375–2614) × light/dark, 24/24 OK. The full-width assertions were replaced. It now checks:
    • main is min(viewport, 96rem) wide with equal side margins.
    • The header is full-bleed, and its row content box matches the main column's edges.
    • Every block in the column, including inside sections, has its content box on those edges, as do text and alerts.
    • Card grids span the column and fill their rows.
    • The only non-none max-width is 1536px, on the header row and main.
    • No reference area and no backfill alert are present.
    • All earlier checks still pass: header center line 23.5px, separator 16px, rows, plots, x-axes, footers, no overflow or wrapping.
  • Content edges: 16..359 at 375 · 24..1416 at 1440 · 216..1704 at 1920 · 563..2051 at 2614.
  • Negative control: the same script against the current live site fails at 1920 (width, edges, max-width, reference area, alert).

🤖 Generated with Claude Code

The header row and main share max-w-(--breakpoint-2xl) (96rem), centered,
following the shadcn/ui site's container; the header border stays
full-bleed. Every block keeps the block's px-4 / lg:px-6, so all content
shares the same left and right edges.

Remove the backfilled-days shading on the Users and VMs charts, the table
marker and the explanatory alert. /api/data still exposes `backfilled`, and
app/README.md explains it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@vercel

vercel Bot commented Oct 29, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
pha-circulation-server Ready Ready Preview Oct 29, 2026 3:45am UTC

Request Review

@kingsleydon
kingsleydon merged commit 3b92242 into main Oct 29, 2026
6 checks passed

This branch was successfully deployed

1 active deployment
Preview — 7ea36e42 Deployed Oct 29, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant