Fix OCR language model switching - #264
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes OCR language switching by ensuring the recognition model actually changes when the user selects a different language, and by keeping the standalone TextRecognition instance in sync with the main PaddleOCR pipeline.
Changes:
- Introduces a language→recognition-model mapping for PP-OCRv5 recognition while keeping the existing detection model.
- Initializes the recognition model selection consistently at startup (based on
--lang) and rebuilds both OCR pipeline + standalone recognizer when the selection changes. - Restores the previously selected language when reopening the language dialog.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The language dialog passed both
langand fixed detection/recognition model names toPaddleOCR. PaddleOCR ignoreslangwhen model names or directories are provided, so selecting another language did not actually switch the recognition model. The standaloneTextRecognitioninstance used by re-recognition also remained on the old model.Changes
--langVerification
python -m py_compile PPOCRLabel.pyen_PP-OCRv5_mobile_recfor bothPaddleOCRandTextRecognition, keepsPP-OCRv5_mobile_det, and restores English in the dialoggit diff --check