Skip to content

fix: Migrate Ruff action to astral-sh/ruff-action@v3 - #62

Merged
m0hamed-ait merged 1 commit into
mainfrom
chore/migrate-ruff-action-v3
Sep 8, 2026
Merged

m0hamed-ait merged 1 commit into
mainfrom
chore/migrate-ruff-action-v3

Conversation

@m0hamed-ait

@m0hamed-ait m0hamed-ait commented Sep 8, 2026 •

Copy link
Copy Markdown
Contributor

Summary of Changes

Migrating the Ruff GitHub Action from chartboost/ruff-action to astral-sh/ruff-action@v3 pinned to version 0.16.0.

  • Replaced chartboost/ruff-action@v1 with astral-sh/ruff-action@v3 pinned to version: 0.16.0.
  • Reconciled workflow inputs and dropped legacy chartboost-only parameters.
  • Applied automated lint/import formatting fixes.

@ostorlab-ai-pr-review

Copy link
Copy Markdown

📊 PR Complexity Assessment: Simple (Score: 1/5)

Small, low-risk maintenance PR migrating the Ruff GitHub Action from chartboost/ruff-action@v1 to the official astral-sh/ruff-action@v3, pinned to ruff 0.16.0, plus a purely cosmetic multi-line import reformat in agent/trufflehog_agent.py (~19 LOC across 2 files, no logic changes). The main considerations are CI behavior parity (the second lint step now relies on the new action's default args after dropping legacy parameters) and verifying the pinned ruff version resolves and produces no new violations. Runtime code and public contracts are unaffected. Not an auto-merge candidate solely because a CI/CD workflow file is modified, which counts as a sensitive path.

🔍 Complexity Drivers

  • Third-party GitHub Action swap (chartboost/ruff-action@v1 → astral-sh/ruff-action@v3) in CI workflow with supply-chain implications
  • Explicit ruff version pin (0.16.0) changes the effective linter version, which could surface new lint/format violations
  • Second lint step now relies on the new action's default args after dropping legacy chartboost-only parameters (implicit behavior dependency)
  • Cosmetic import reformatting in agent source file (no logic change, but touches production code)

🎯 Suggested Attention Areas

  • .github/workflows/lint_format_checker.yaml (Action migration and version pinning parity): Verify the astral-sh/ruff-action@v3 input schema (version, args) is used correctly, that the second 'Running linter.' step's default args (check) match the previous chartboost v1 behavior since legacy args were dropped, and that ruff version 0.16.0 resolves correctly to avoid CI bootstrap failures.
  • .github/workflows/lint_format_checker.yaml (Supply-chain pinning of third-party action): The action is referenced by the mutable tag @V3 rather than a commit SHA. Confirm this complies with org supply-chain policy for third-party GitHub Actions, or consider SHA-pinning. Note ruff itself is now explicitly pinned to 0.16.0, which changes the effective linter version from whatever chartboost v1 resolved — confirm no new lint/format violations appear.
  • agent/trufflehog_agent.py (Import reformatting correctness): Confirm these are purely cosmetic import reformats (multi-line parenthesized imports with trailing commas) with no dropped or renamed symbols. The trailing commas rely on the formatter's magic-trailing-comma behavior to keep ruff format --check stable under the newly pinned ruff 0.16.0; verify CI formatting check passes with that exact version.

⚠️ Sensitive Paths Touched

  • .github/workflows/lint_format_checker.yaml

⚡ Auto-Merge Assessment

❌ Not recommended for auto-merge — manual peer review required.

💡 PR Decomposition Recommendation

null

@ostorlab-ai-pr-review ostorlab-ai-pr-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review Summary

Total Issues Found: 2 (both minor style/convention suggestions)
Critical Issues (Bugs): 0
Security Issues: 0

The implementation is functionally sound with no correctness or security concerns. The only findings are two instances of grouped parenthesized imports in agent/trufflehog_agent.py that should follow the project's one-import-per-symbol convention. These are trivial, mechanical fixes with zero behavioral impact. After applying these import reformats, the PR is ready to merge.

Comment thread agent/trufflehog_agent.py
Comment thread agent/trufflehog_agent.py

@Oussama-Bakri Oussama-Bakri left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@m0hamed-ait
m0hamed-ait merged commit cad50b5 into main Sep 8, 2026
6 checks passed
@m0hamed-ait
m0hamed-ait deleted the chore/migrate-ruff-action-v3 branch September 8, 2026 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants