Repository navigation
pwgtopdf: reject a non-positive pclm-strip-height-preferred - #289
Open
ManasBagul23 wants to merge 1 commit into
Open
ManasBagul23 wants to merge 1 commit into
ManasBagul23 wants to merge 1 commit into
Conversation
cfFilterPWGToPDF() copies the printer's pclm-strip-height-preferred IPP attribute straight into pdf.pclm_strip_height_preferred with no range check, then uses it as both a divisor and a modulo operand while computing the PCLm strip count and strip boundaries. A PPD or printer-attribute value of zero reaches that math unchanged and terminates the standalone pwgtopclm filter with SIGFPE before any raster row is processed -- a job-level denial of service triggerable through printer capability data. Only accept the attribute when it's a positive integer; fall back to the existing default strip height (16) otherwise, same as when the attribute is absent. Fixes OpenPrinting#177
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
cfFilterPWGToPDF()copies the printer'spclm-strip-height-preferredIPP attribute straight intopdf.pclm_strip_height_preferredwith no range check, then uses it as both a divisor and a modulo operand while computing the PCLm strip count and strip boundaries:A PPD or printer-attribute value of zero reaches that math unchanged and terminates the standalone
pwgtopclmfilter with SIGFPE before any raster row is processed -- a job-level denial of service triggerable through printer capability data.Verified with a standalone build of the attribute-fetch-then-divide logic: a
0attribute value crashes with a hardware divide-by-zero exception before the fix, and falls back to the default strip height (16) cleanly after it.Fix
Only accept the attribute when it's a positive integer; fall back to the existing default strip height (16) otherwise, same as when the attribute is absent.
Fixes #177