Skip to content

refactor(cardwired): Correctly identify GPU types, and improve reliability - #234

Draft
luytan wants to merge 1 commit into
mainfrom
correct_gpu_type_detection
Draft

refactor(cardwired): Correctly identify GPU types, and improve reliability#234
luytan wants to merge 1 commit into
mainfrom
correct_gpu_type_detection

Conversation

@luytan

@luytan luytan commented Sep 8, 2026

Copy link
Copy Markdown
Member

Description

Add a GpuType enum, improve code readability, add more reliable discrete checks and change systemd service to start after nvidia modprobe

Checklist:

  • My code follows the style guidelines of this project (cargo fmt)
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the mdBook documentation
  • My changes generate no new warnings (clippy/clang)
  • New and existing unit tests pass locally with my changes (either use nix flake check or wait for the ci)

@coderabbitai

coderabbitai Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@luytan luytan mentioned this pull request Sep 8, 2026
@luytan
luytan force-pushed the correct_gpu_type_detection branch from 0c2306c to 178779c Compare September 8, 2026 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant