fix: rename ManufacturingStatus bit 15 CAL_TEST to CAL_EN - #92
Open
amandeavor wants to merge 1 commit into
Open
amandeavor wants to merge 1 commit into
amandeavor wants to merge 1 commit into
Conversation
From R3 onwards the TRM calls bit 15 CAL_EN (calibration mode). The manifest still used the older CAL_TEST name. Pure identifier rename on r3/r4/r5; regenerated device-driver pregen sources. Fixes OpenDevicePartnership#84
amandeavor
requested review from
chchongmsft,
colindonahue,
seanbrns and
thdesil
September 25, 2026 07:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #84.
From R3 onwards TI names
ManufacturingStatusbit 15 CAL_EN ("CALIBRATION mode"). The manifest still exposed it asCAL_TEST, so anyone following the TRM calibration procedure could not findcal_en()in the driver.Pure rename on
device_r{3,4,5}.yaml(r1 keepsCAL_TEST). Regeneratedgen_r{3,4,5}.rs.Breaking: public accessor
cal_test()→cal_en()on r3/r4/r5.Test plan
cargo test --locked --features r5(21 passed)