fix(ci): restore checks and add cargo test workflow - #62
Merged
Merged
Conversation
tullom
commented
Sep 24, 2026
tullom
commented
Contributor
- Resolve Clippy errors in retry writes and buffer flushing
- Fix the PEC retry test import and add flush regression coverage
- Correct timeout feature flags and pin device-driver-cli to 1.0.9
- Upgrade defmt to 1.1.1 to remove the unmaintained proc-macro-error2
- Refresh trusted dependency audits and prune obsolete imports
- Test all chip revisions with timeout and PEC lookup-table variants
- Document local test commands
tullom
requested review from
chchongmsft,
colindonahue,
seanbrns and
thdesil
September 24, 2026 17:28
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Remove the duplicate aggregated-from audit source entry.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: None
What changed in this PR
Restores CI checks, expands test coverage, fixes retry/flush behavior, and updates dependencies and audit metadata.
Changes:
- Adds matrix testing across chip revisions and features.
- Fixes interface retry/flush code and regression coverage.
- Updates tooling, dependencies, and supply-chain audits.
- Documents local test commands.
| File | Summary |
|---|---|
supply-chain/imports.lock |
Refreshes dependency audits; removes duplicate provenance entry. |
src/tests.rs |
Adds flush regression coverage. |
src/interface.rs |
Fixes retry buffer handling and flushing. |
README.md |
Documents testing commands and workflow status. |
Cargo.lock |
Updates defmt dependencies. |
.github/workflows/test.yml |
Adds revision and feature-matrix testing. |
.github/workflows/device-driver.yml |
Pins the device-driver CLI version. |
.github/workflows/check.yml |
Corrects feature configuration. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Resolve Clippy errors in retry writes and buffer flushing - Fix the PEC retry test import and add flush regression coverage - Correct timeout feature flags and pin device-driver-cli to 1.0.9 - Upgrade defmt to 1.1.1 to remove the unmaintained proc-macro-error2 - Refresh trusted dependency audits and prune obsolete imports - Test all chip revisions with timeout and PEC lookup-table variants - Document local test commands
tullom
force-pushed
the
fix-failing-ci
branch
from
September 24, 2026 17:33
dbf08b6 to
c03987d
Compare
tullom
requested review from
RobertZ2011,
felipebalbi,
jerrysxie and
kurtjd
and
a lite review from Copilot
September 24, 2026 17:34
kurtjd
approved these changes
Sep 24, 2026
RobertZ2011
approved these changes
Sep 24, 2026
seanbrns
approved these changes
Sep 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.