fix: redact secrets from audit errors - #21
Merged
haolpku merged 1 commit intoSep 20, 2026
Merged
Conversation
haolpku
requested changes
Sep 20, 2026
haolpku
left a comment
haolpku
left a comment
Collaborator
There was a problem hiding this comment.
Requesting changes because the new error-text redaction misses common JSON/dict-shaped diagnostics. For example, {"api_key": "sk-live-secret"} has a quote between the key and colon, so _SECRET_TEXT_RE does not match it. Please cover quoted keys plus credential-shaped raw tokens (at minimum sk-...) and add regression cases for JSON/dict and URL/query-string error text.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AuditLogHook redacted secret-shaped argument keys but wrote exception text verbatim. Provider and transport failures can include API keys or bearer tokens, so failed tool calls could persist credentials in audit.jsonl. Added narrow text redaction for key=value/key: value and Bearer formats, plus a regression covering an exception path. Validation: 30 hook tests passed, 5 optional SDK tests skipped; hash-chain behavior remains covered; no API changes; targets main.