fix: preserve relation- and origin-distinct graph paths - #15
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Graph traversal currently drops parallel relations and distinct evidence origins because it deduplicates paths by node sequence. For example,
A --authored--> BandA --reviewed--> Breturn only whichever relation was inserted first.Return paths distinguished by their stored edge sequences. Enumerate each keyed edge separately, retain per-path cycle detection and relation filtering, and stop expansion at the result budget. Use deterministic target/relation/edge-key ordering so capped results do not depend on insertion order. Document that score sorting applies to the bounded BFS selection, not exhaustive global top-k search.
Validation: 10 focused cases cover parallel relations and multihop continuation, distinct origins including profile/runtime edges, repeated upserts, insertion-order reversal with and without caps, cycles, filters, hop/result bounds, and persistence/reload. Five of these cases fail on the previous main; all ten pass with this change. Full regression: 235 passed, 5 skipped.
Fixes #10.