fix: serialize graph persistence and preserve dirty state for mutations occurring during a save - #13
Merged
haolpku merged 2 commits intoSep 17, 2026
Conversation
Contributor
Author
|
@haolpku — Could you please review the deterministic graph persistence-race fix and merge it if CI confirms the full suite? The PR explicitly does not claim cross-process locking or fsync durability. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@haolpku
Summary
NetworkX graph persistence now captures immutable revisions, serializes writes per store, preserves dirty state when a mutation happens during a save, and uses a unique temporary file for each atomic replacement.
Root cause
The old worker iterated the live graph and unconditionally set
_dirty = Falseafter the write. A mutation could land after the worker captured the old graph but before that reset, leaving newer in-memory data absent from disk while the next persist returned early. Concurrent writes also shared one PID-derived temporary filename.Change
persistcalls with an async lock.Regression coverage
Barrier/event-driven tests cover mutation during save, overlapping saves, unique latest-file results, write failures, retry behavior, and existing graph traversal/reload behavior.
Verification:
python -m pytest -q— 197 passing, 5 optional SDK tests skipped.The patch is intentionally in-process. It does not claim cross-process locking, fsync durability, or a storage-format migration.
Please review the concurrency model and merge if CI is green.