Repository navigation
fix: evaluate only the requested metadata comparator - #11
Merged
haolpku merged 1 commit intoSep 17, 2026
Merged
Conversation
Contributor
Author
|
@haolpku — Could you please review this focused metadata-comparator fix and merge it if CI confirms the full no-network suite? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@haolpku
Summary
Metadata filters now evaluate only the comparator requested by the caller.
Root cause
matches_metadatabuilt a dictionary of all eight boolean comparator results before selectingop. For numeric equality or ordering, the unrelated membership expression could raiseTypeError; for string membership, an unrelated ordering expression could fail. The broad handler then converted valid matches into false negatives.Change
$and/$or, scalar shorthand, and supported operator validation unchanged.Regression coverage
The new tests cover true and false cases for all eight operators plus nested boolean filters, including the original numeric equality, numeric greater-than, and string membership witnesses.
Verification:
python -m pytest -q— 211 passing, 5 optional SDK tests skipped.No dependencies, public filter schema, or provider behavior outside comparator dispatch changed.
Please review and merge if CI confirms the focused fix.