1.12.2 Frustum Optimization Forward-Port - #85
Open
Zonix-Official wants to merge 3 commits into
Open
Conversation
…1.21.6 for CC3
Member
|
|
DaMatrix
reviewed
Sep 3, 2026
DaMatrix
left a comment
DaMatrix
left a comment
Member
There was a problem hiding this comment.
why not leave the original comments? or write better ones if you don't like them (i admit that mine may be somewhat inscrutable to anyone other than me), but this code is somewhat incomprehensible by itself
Author
|
I left out the comments when writing the code, admittedly I didn't do a direct copy + paste and went about it by referencing piece by piece; starting with cleanup of the vanilla loop, then getting the rest of the logic converted correctly adding my comments as a final step before the PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For my first contribution to CC3; with permission of DaPorkchop, I have ported their 1.12.2 Frustrum Optimization PR (OpenCubicChunks/CubicChunks#782) into CC3 on 1.21.6
I tackled this as this felt like a decent first thing for me to ease myself into such a large project like this, hoping over the coming days/weeks I can contribute much more significant developments.