Add full-flow behat + playwright coverage for GSSP service name#95
Open
kayjoosten wants to merge 2 commits into
Open
Add full-flow behat + playwright coverage for GSSP service name#95kayjoosten wants to merge 2 commits into
kayjoosten wants to merge 2 commits into
Conversation
…mdui:UIInfo Adds a behat feature that exercises the cross-repo service name flow: the SP includes an mdui:UIInfo/mdui:DisplayName extension in the SFO AuthnRequest, the Stepup-Gateway (with feature flag enable_service_name_from_saml_authnrequest enabled) forwards it in the proxy AuthnRequest to the GSSP, and the demo GSSP displays the service name on its authentication page. The devssp test SP does not support the mdui:UIInfo extension yet, so a patched sp.php with an mdui_displayname form field is mounted over the one in the devssp container, pending upstream inclusion in OpenConext-devssp.
Playwright suite exercises the mdui:UIInfo service-name flow end to end against the running devconf stack, complementing the existing behat scenario. Also adds a missing "on the GSSP registration page" assertion step alongside the existing authentication-page one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
stepup/ssp/sp.php(mounted over the stock devssp SP) withmdui:UIInfo/mdui:DisplayNameextension support, since the stock SP image doesn't support itgssp_service_name.feature: SP → Gateway → GSSP, asserting the service name from the AuthnRequest shows on the GSSP page@SKIPuntilStepup-Gateway#624merges and releases in the test imageHow to test locally against the in-flight feature branches
Or run the playwright suite in
stepup/tests/playwright/(see its README).Note: this exercises Gateway → GSSP directly via the SSP test SP, not the full production path through EngineBlock (EngineBlock#2034 handles that leg separately).