fix: refuse headless --url pin for authoring login - #51
Merged
Conversation
--url launches Playwright Chromium with empty cookies, not the Chrome window the person already signed into. Without --headed they cannot sign in there. Fail closed and tell them to pass --headed plus pause_for_input, or omit --url after a unique frontmost Chrome window.
Member
Author
|
Merged by an agent session, not the founder. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
--urlstill launches a fresh Playwright Chromium with empty cookies. That is not the Chrome window the person already signed into, and without--headedthey cannot sign in there at all.Headless
--urlused to open a session nobody can type into. The pin now fails instead.What
pin_local_backendrefuses--urlunlessheadedis true. The error tells the operator to pass--headedandpause_for_input, or to omit--urland pin the unique frontmost Chrome window after they sign in (macOS; no DOM identity).README and
serve --authoringhelp say the same thing.--urldoes not attach over CDP.A test covers the secret-login pause:
pause_for_inputthencontinue_input(record_observed), thencompilereturnsneeds_human_admit. It does not open a real site.Reviewer
--urlwithout--headedraises and does not launch Chromium.--url --headedstill calls_pin_web.type_textfor the human field.Debug-port attach stays out of v1. This package still has no
expect_downloador file-chooser hook; a download is a recorded click on the web backend.Opened by an agent session, not the founder