Repository navigation
Fix production chat handshake timeout and Apollo warnings - #2451
Merged
Merged
Conversation
ReviewOverall this is a small, focused fix and it looks sound. A few notes: Maintainability
Frontend
Build
Security / performance
The changelog fragment is present and follows the convention. LGTM with the above as suggestions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New corpus questions intermittently failed with HTTP 502 because database-backed corpus, access, and agent lookups exceeded Daphne's default five-second WebSocket handshake deadline. Allow 30 seconds in production startup commands. The matching GKE manifest change is tracked in https://github.com/Open-Source-Legal/opencontracts-infra/pull/30; its timeout mitigation is already running on both production replicas.
Production bundles also left Apollo's development checks enabled, producing encoded deprecation warnings. Define its development flag at build time. Show chat transport failures and reconnect without reloading the page or losing a drafted question.
Validation:
globalThis.__DEV__checks remain in the generated JavaScript.