Common initialiseGLWithSize method - #719
Merged
Merged
Conversation
Occurs on some systems eg. when going fullscreen -> window or vice versa Remove uncalled code
Occurs on some systems eg. when going fullscreen -> window or vice versa Remove uncalled code
Occurs on some systems eg. when going fullscreen -> window or vice versa Remove uncalled code
mcarans
requested review from
AnotherCommander,
Kaks,
KonstantinosSykas,
dsalt,
ericwalch,
jobi-wan,
kanthoney,
mwerle,
oocube and
phkb
as code owners
August 19, 2026 23:04
Closed
phkb
approved these changes
Aug 19, 2026
Contributor
|
Works well from my end. |
Contributor
Author
|
@LW-archlinux please can you check it works for you |
|
Nothing weird noticed with this applied to master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove Windows custom logic
Add one hack for Windows SDL3 pause issue: libsdl-org/SDL#12791 that occurs on some systems eg. when going fullscreen -> window or vice versa
Remove dead code
@phkb Should be almost the same as what you tested but I had to change order of calls for Linux to work