Repository navigation
Fix duplicate checker accuracy and add regression coverage - #32
Merged
Merged
Conversation
Contributor
✅ No duplicate payload entries detectedChecked 0 normalized entries from added/modified payload files on the latest push. Posted automatically by the Duplicate Payload Check workflow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix incorrect duplicate-check results for moved/deleted payload files and misleading PR line numbers. Compare complete merge-base/head contents so diff-like payload prefixes and truncated patches cannot hide additions.
Preserve whitespace in exact comparisons and report whitespace-only matches as advisory. Only exact duplicates fail the check and apply the duplicate label. Unreadable or incomplete payload data now causes an error instead of a successful partial scan.
Add an offline regression suite and a read-only CI workflow. Update contributor guidance and replace copied, unrelated instructions in eight category READMEs with context-specific validation guidance.
Motivation / Security-Research Context
Payload whitespace and protocol framing can affect behavior. Contributors need accurate locations and reliable duplicate checks without executing payloads.
Affected Category
Repository automation and documentation. No payload files changed.
Duplicate Check
Not applicable to payload additions: no payload entries were added or removed. Existing duplicate groups were left for contextual review.
Validation Performed
python -m unittest discover -s scripts -p 'test_*.py' -v: 13 tests passed on Python 3.10.git diff --cached --check: passed before commit.The existing privileged duplicate-check workflow intentionally runs base-branch code, so this PR's new implementation is exercised by the new regression workflow and will take effect in that workflow after merge.
Source Attribution and References
N/A; fixes based on repository review and synthetic reproductions.
AI-Assisted Contribution Disclosure
Licensing and Originality
Changes are original repository maintenance and contain no credentials, secrets, or private/customer data. Submitted under the repository's MIT License.
Responsible Use Confirmation
This change only reads synthetic or repository text and is consistent with the authorized-testing-only scope in DISCLAIMER.md.